Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UI #700

Merged
merged 1 commit into from
May 4, 2022
Merged

Fix UI #700

merged 1 commit into from
May 4, 2022

Conversation

TG1999
Copy link
Contributor

@TG1999 TG1999 commented Apr 14, 2022

Add aliases in vulnerability view and fix some typos. Also get rid of redundant packages

Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com

@TG1999 TG1999 force-pushed the ui-fix branch 3 times, most recently from 46aef78 to 96af362 Compare April 15, 2022 19:17
@TG1999 TG1999 changed the title UI fixes Fix UI Apr 18, 2022
@TG1999 TG1999 force-pushed the ui-fix branch 3 times, most recently from 383dcbc to 8835388 Compare April 22, 2022 19:11
@TG1999
Copy link
Contributor Author

TG1999 commented Apr 22, 2022

Screenshot from 2022-04-23 00-28-05

Table View for Packages

This was linked to issues Apr 22, 2022
Aliases not displayed in UI and API #675
Closed
Use shorter VULCOID #695
Closed
Show packages in table view in UI #707
Closed
Data displayed in UI is not correct #708
Closed
@TG1999 TG1999 force-pushed the ui-fix branch 5 times, most recently from 8b5122f to 1efb3e1 Compare April 28, 2022 14:56
pombredanne
pombredanne reviewed May 2, 2022
View reviewed changes
vulnerabilities/api.py Outdated Show resolved Hide resolved
pombredanne
pombredanne requested changes May 2, 2022
View reviewed changes
Copy link
Collaborator

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
See the change wrt. vulcoid -> vulnerability_id.

vulnerabilities/api.py Show resolved Hide resolved
vulnerabilities/api.py Outdated Show resolved Hide resolved
vulnerabilities/migrations/0012_vulnerability_vulcoid.py Outdated Show resolved Hide resolved
@TG1999 TG1999 mentioned this pull request May 3, 2022
Closed
@TG1999 TG1999 force-pushed the ui-fix branch 2 times, most recently from 1ea8d88 to f951e46 Compare May 3, 2022 10:09
pombredanne
pombredanne reviewed May 4, 2022
View reviewed changes
Copy link
Collaborator

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the model changes working OK on an existing database?
Have you tried to:

  1. on the main branch code, run some imports + improve
  2. switch to this branch, and apply the migrations. Are things working OK?

@TG1999
Copy link
Contributor Author

TG1999 commented May 4, 2022

Are the model changes working OK on an existing database? Have you tried to:

  1. on the main branch code, run some imports + improve
  2. switch to this branch, and apply the migrations. Are things working OK?

Yes it is working, adding some snippets here

./manage.py import vulnerabilities.importers.nginx.NginxImporter
Importing data using vulnerabilities.importers.nginx.NginxImporter
Successfully imported data using vulnerabilities.importers.nginx.NginxImporter
./manage.py improve vulnerabilities.importers.nginx.NginxBasicImprover
Improving data using vulnerabilities.importers.nginx.NginxBasicImprover
Successfully improved data using vulnerabilities.importers.nginx.NginxBasicImprover
git checkout ui-fix
Switched to branch 'ui-fix'
./manage.py migrate
Operations to perform:
Apply all migrations: admin, auth, authtoken, contenttypes, sessions, vulnerabilities
Running migrations:
Applying vulnerabilities.0011_vulnerability_packages_alter_package_vulnerabilities_and_more... OK
Applying vulnerabilities.0012_alter_vulnerability_vulnerability_id... OK
Applying vulnerabilities.0013_auto_20220503_0941... OK

@TG1999
Reference aboutcode-org#707, aboutcode-org#695, aboutcode-org#675 and a…
02b204a 
…boutcode-org#708

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
pombredanne
pombredanne approved these changes May 4, 2022
View reviewed changes
Copy link
Collaborator

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. Merging!

@pombredanne pombredanne merged commit f563c64 into aboutcode-org:main May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@TG1999 @pombredanne